Skip to content

feat: messageType and spaceId #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

feat: messageType and spaceId #314

wants to merge 11 commits into from

Conversation

mohitpubnub
Copy link
Contributor

@mohitpubnub mohitpubnub commented Mar 7, 2023 •
edited
Loading

  • add support of type and spaceId for subscribe, publish, file_publish and fetch_messages.

@mohitpubnub mohitpubnub added priority: none This PR has no priority - can be reviewed any time. type: feature This PR contains new feature. type: test This PR contains new tests for existing functionality or fixes to existing tests. labels Mar 7, 2023
@mohitpubnub mohitpubnub marked this pull request as ready for review March 27, 2023 06:04
@mohitpubnub mohitpubnub requested a review from parfeon as a code owner March 27, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parfeon parfeon Awaiting requested review from parfeon parfeon is a code owner

1 more reviewer

@are are are approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
priority: none This PR has no priority - can be reviewed any time. type: feature This PR contains new feature. type: test This PR contains new tests for existing functionality or fixes to existing tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohitpubnub @are